fix: sessions backround sharedworker truly shared #14180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
shared-sharedworker
branch
6 times, most recently
from
b16feb9
to
d4e3fa9
Compare
mroz22
changed the title
mroz22
force-pushed
the
shared-sharedworker
branch
from
ceaa440
to
0f57e29
Compare
mroz22
commented
Sep 9, 2024
mroz22
commented
Sep 9, 2024
mroz22
force-pushed
the
shared-sharedworker
branch
from
0f57e29
to
3b0ea62
Compare
mroz22
force-pushed
the
shared-sharedworker
branch
5 times, most recently
from
a30664f
to
c43f2b0
Compare
mroz22
requested review from
Nodonisko,
a team,
szymonlesisz and
martykan
as code owners
mroz22
changed the title
mroz22
force-pushed
the
shared-sharedworker
branch
from
c26c6aa
to
b5c39e8
Compare
mroz22
commented
Sep 26, 2024
mroz22
commented
Sep 26, 2024
…ation with apps using connect
marekrjpolak
force-pushed
the
shared-sharedworker
branch
from
f221b60
to
e60cf24
Compare
marekrjpolak
approved these changes
Sep 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connect-iframe has been bundled into suite-web since the very beginning. This, however, caused a problem: the shared workers used for synchronizing device access between tabs were not really shared (between suite-web and connect) because there were two of them at the same time.
The tldr change by this PR is that from now on the single source of the sharedworker is @trezor/connect-web deployment and suite-web may be merely pointed to it.
Related Issue
Resolve #12002
Screenshots:
note: screenshots are outdated. I changed the naming later.
Before:
After:
Test env